Am 07/17/16 um 12:04 schrieb Robert Scholte: > On Sun, 17 Jul 2016 09:49:39 +0200, Hervé BOUTEMY <[email protected]> > wrote: > >> I worked on documentation to finish from my pov my work on this API: >> http://maven.apache.org/shared-archives/maven-shared-utils-LATEST/ >> >> I'd like to release maven-shared-utils 3.1.0 to start releasing plugins >> with >> styled messages, and of course work on releasing Maven 3.4.0-SNAPSHOT >> >> any objection? >> any improvement? > > I'd love to see only MessageBuffer#method(Object message) signatures, so > we can remove the reset() since the already call reset() within those > methods. > Now it is a mixture of 2 concepts: one were the developer is responsible > for resetting it and the concept where every method does already the reset. > This will reduce the number of methods and we have one clear concept.
+1 Reading 'MessageBuffer' I was missing error(Object) debug(Object) info(Object) How the methods not taking an Object are meant to be used wasn't quite clear until reading the source. Maybe also use 'append' instead of just 'a'. Maybe the interface should be named 'MessageBuilder' instead of buffer. Regards, -- Christian --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
