On Sun, 17 Jul 2016 20:49:52 +0200, Christian Schulte <[email protected]>
wrote:
Am 07/17/16 um 12:04 schrieb Robert Scholte:
On Sun, 17 Jul 2016 09:49:39 +0200, Hervé BOUTEMY
<[email protected]>
wrote:
I worked on documentation to finish from my pov my work on this API:
http://maven.apache.org/shared-archives/maven-shared-utils-LATEST/
I'd like to release maven-shared-utils 3.1.0 to start releasing plugins
with
styled messages, and of course work on releasing Maven 3.4.0-SNAPSHOT
any objection?
any improvement?
I'd love to see only MessageBuffer#method(Object message) signatures, so
we can remove the reset() since the already call reset() within those
methods.
Now it is a mixture of 2 concepts: one were the developer is responsible
for resetting it and the concept where every method does already the
reset.
This will reduce the number of methods and we have one clear concept.
+1
Reading 'MessageBuffer' I was missing
error(Object)
debug(Object)
info(Object)
How the methods not taking an Object are meant to be used wasn't quite
clear until reading the source. Maybe also use 'append' instead of just
'a'. Maybe the interface should be named 'MessageBuilder' instead of
buffer.
Regards,
It took a while for me too to understand what 'a' meant. Within the JAnsi
API it is easier to chain because it is short, and Hervé want to keep this
option in this API for the short chaining. I'd prefer to have an alias
method for it, either 'append(Object)' (although all methods already do so
too) or text(Object) or plain(Object) to describe the style.
And yes, it is a Builder-pattern, so maybe MessageBuilder is more clear,
although I wouldn't mind if it would stay MessageBuffer.
thanks,
Robert
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
