Sorry I could not get back to ML earlier. I got home early morning and could not work in ASF. I spent hours around my Nisan. It was so cold that my car could not start up and the electronics in Nisan was totally crazy and could not lock the car. We moved father's car from pumping station because it suddenly freeze as well. So yesterday everything what could be broken was broken totally. I need a day to get everything to normal and then I will participate in ASF very soon.
On Sun, Jan 8, 2017 at 9:31 AM, Christian Schulte <schu...@apache.org> wrote: > Am 01/08/17 um 06:48 schrieb Tibor Digana: > > Christian, > > !!! Stop committing to the project immediatelly !!! > > Issue making that IT fail is in this commit > <https://git-wip-us.apache.org/repos/asf?p=maven- > surefire.git;a=commitdiff;h=b50ea3acf0701e4a66ad8f55930cb41dd2bfc999>. > > In class 'ThreadedStreamConsumer', you changed > > thread.join() > > to > > if ( thread.isAlive() ) > { > thread.join( SECONDS.toMillis( 10L ) ); > thread.interrupt(); > } > > That call to interrupt seems to be an issue. You do need to join on that > thread. It's important it does call consume with all remaining items. > Interrupting appears incorrect to me. I changed that locally to > > if ( thread.isAlive() ) > { > thread.join(); > } > > and the IT started to succeed again. See the attached patch. With this > patch applied, all ITs are passing here locally now. > > > >
