Am 01/08/17 um 04:04 schrieb Tibor Digana:
> Currently Jenkins build fails on OOM not because of I/O streams but because
> of missing this code
> 
> ThreadedStreamConsumer which was introduced by Kristian Roselvold with
> a purpose.
> 
> Now we can do it better using LinkedBlockingQueue put()/take().
> 
> 
> public void consumeLine( String s )
>     {
>         items.add( s );
>         if ( items.size() > ITEM_LIMIT_BEFORE_SLEEP )
>         {
>             try
>             {
>                 Thread.sleep( 100 );
>             }
>             catch ( InterruptedException ignore )
>             {
>             }
>         }
>     }

If you already found the issue, just commit it. I just created

<https://issues.apache.org/jira/browse/MSHARED-610>

which may have an impact on
'org.apache.maven.plugin.surefire.report.StatelessXmlReporter' using it.
Will take a look at it tomorrow and see what can be done about it in the
shared utils. Turns out lack of PrintWriter/PrintStream checkError calls
became just another item on my ever growing list of pitfalls you can run
into. I wonder if Findbugs would have warned about it. If things like
this appear in some shared utility, a lot of things may be impacted by
it without noticing due to silently discarding exceptions.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to