On Thu, Mar 12, 2020 at 2:46 PM Robert Scholte <[email protected]> wrote: > > This week I was very surprised to see commits from the user call "github" in > Jenkins: > https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes > > > IMO we shouldn't want these kind of commits. > Based on the most recent activities I had a chat with Sylwester en Elliotte. > > The reason is the author of these commits was Elliotte, but the committer > Github > https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git&a=commit&h=8ed3e6827885a161a8802100f0f50968555356b0 > > > Elliotte tried to figure it out, and his conclusion was that in case he > squashed and merged commits via github, the committer became github. > > If this is indeed the case, we should always ask the author to squash his > commits so we can track the commit better, and it makes it easier to find > possible regressions (and revert them when necessary) >
That sounds backwards. Squashing is what makes Github the committer. Do we care if Github is the committer? Squashing is pretty common. The developer is still listed as the author. Can we simply look at the author and ignore the committer? -- Elliotte Rusty Harold [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
