On Sat, Mar 14, 2020 at 6:22 AM Robert Scholte <[email protected]> wrote: > > Yes, once confirmed that the branch builds fine on our Jenkins, we should do > the "squash and merge". (we should already be happy with a proper PR) > My experience so far was like you describe, but it doesn't explain why > Elliotte causes "github" to become the committer. > One possible difference I see is that he's both the author and committer. > I never push my commits via github, but always via gitbox. >
My current hypothesis, based on limiting testing, is that anytime someone uses the "Squash and Merge" button on Github, then Github is marked as the committer. It's possible, as Robert suggests, that this is only the case when the original committer is doing the "Squash and Merge" and not when someone else pushes the button but I have not tested that. -- Elliotte Rusty Harold [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
