Am 2020-03-12 um 19:46 schrieb Robert Scholte:
This week I was very surprised to see commits from the user call "github" in
Jenkins:
https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes
IMO we shouldn't want these kind of commits.
Based on the most recent activities I had a chat with Sylwester en Elliotte.
The reason is the author of these commits was Elliotte, but the committer Github
https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git&a=commit&h=8ed3e6827885a161a8802100f0f50968555356b0
Elliotte tried to figure it out, and his conclusion was that in case he
squashed and merged commits via github, the committer became github.
If this is indeed the case, we should always ask the author to squash his
commits so we can track the commit better, and it makes it easier to find
possible regressions (and revert them when necessary)
Not sure if this would help, but my WOW is creating a patch from github, and
applying it to the gitBOX url. Squashing and merging it from here would at
least make me the committer.
I highly dislike the squash feature in GitHub because you are out of
control of the process. Only, Maven committers, shall be in the
committer field. Third parties are not trustworthy for me.
Me process for the last couple of years with PRs was
* Request a squash from a submitter
* Pull that branch into my local clone
* Run tests (locally, Jenkins)
* Adjust message
* Merge into master
* Push
This gives me full control before this is written to remote. I simply
don't trust GH, especially not with these ugly merge commits.
M
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
