+1 On Fri, Dec 10, 2021, 20:58 Manfred Moser <manf...@simpligility.com> wrote:
> I totally agree with finally just shipping this. We got this all donated > about two years ago now and there is still nothing shipping. > > I used to just manually do the testing and thousands of projects are > happy. I assume the new project is at least manually testing and works as > before or better. Let's not wait nay more and let perfection get into our > way. It surely is good enough for a release. > > The beauty is that if you find an issue.. you just ship again ... no > reason to wait. > > manfred > > Hervé BOUTEMY wrote on 2021-12-10 04:13 (GMT -08:00): > > > the current 3.1.0-SNAPSHOT works like 0.5.6 as donated: I confess I did > not > > test, I just did not change anything using the general approach "people > were > > happy before, just continue step by step improvements" :) > > > > reading the mvnw script (*nix), compiling+running the .java is executed > only if > > neither wget nor curl are available on your machine > > > > reading the mvnw.cmd, it seems .java is not supported > > > > looking at Git history confirms: > > > https://github.com/apache/maven-wrapper/commit/570bc50afe07bff696a097cd7746d01b00e70337 > > > > > > Don't hesitate to create a Jira issue and corresponding fix to add .java > > support for Windows: future 3.1.0 will have one more fix over previous > 0.5.6 > > > > Regards, > > > > Hervé > > > > Le vendredi 10 décembre 2021, 10:40:41 CET Robert Scholte a écrit : > >> I need more time. > >> > >> e.g. it looks like type=source doesn't use the Java sourcefile to > >> download the wrapper. > >> now that the plugin and wrapper are combined in one project, the ITs are > >> incomplete. > >> They should call both the wrapper-goal and something like 'mvnw > >> --version' to ensure it is working (this used to be done in > >> maven-integration-testing) > >> > >> thanks, > >> Robert > >> > >> ------ Origineel bericht ------ > >> Van: "Hervé BOUTEMY" <herve.bout...@free.fr> > >> Aan: "Maven Developers List" <dev@maven.apache.org> > >> Verzonden: 10-12-2021 08:08:57 > >> Onderwerp: Re: reviewing Maven Wrapper before releasing > >> > >> >thank you to everybody who reviewed, discussed, contributed > >> > > >> >we now have 16 issues fixed, everything seems stable > >> > > >> >if nobody objects, I'll start a release over the week-end > >> > > >> >Regards, > >> > > >> >Hervé > >> > > >> >Le mardi 7 décembre 2021, 00:07:41 CET Hervé BOUTEMY a écrit : > >> >> Hi, > >> >> > >> >> Maven Wrapper has been donated to Apache Maven, imported to > >> >> > >> >>https://github.com/apache/maven-wrapper > >> >> > >> >> Documentation published to https://maven.apache.org/wrapper/ > >> >> > >> >> Here is the list of fixes from previous 0.5.6 release: > >> >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&; > >> >>ve>> > >> >> rsion=12350068 > >> >> > >> >> > >> >> Please test and review so we can do a release soon > >> >> > >> >> Regards, > >> >> > >> >> Hervé > >> >> > >> >> > >> >> > >> >> > --------------------------------------------------------------------- > >> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >> For additional commands, e-mail: dev-h...@maven.apache.org > >> > > >> >--------------------------------------------------------------------- > >> >To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> >For additional commands, e-mail: dev-h...@maven.apache.org > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > >> For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > > For additional commands, e-mail: dev-h...@maven.apache.org > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
