I totally agree that it is a far better aproach to have a child elemnt of the dependency, however, as you said, this requires more changes that are not likely to be on 1.0.x. What I implemented is a less intrusive solution, since properties for dependencies are already there. Future migration should not be a proeblem, since just changing the property to a child element is trivial and easy automatizable, I think that for the short term this can be good. I emphatize for the short term, I don't know if 1.1 will come with changes to the pom, if so, I'd really prefer the child element.
On Wed, 24 Nov 2004 21:36:28 -0200, Felipe Leme <[EMAIL PROTECTED]> wrote: > Miguel, > > Applying such patches are not that easy, as the patch adds a new feature > to the dependency which I'm not sure if it's the right one. > > I mean, I liked your patch, but I would prefer that the comment was a > child element of the dependency, as Michal suggested. But then it would > requires a change in the POM DTD, which would only work on Maven 1.1 and > POM v4. > > So, I think this issue should better discussed in the list (or better > yet, at the Jira entry) before we take any action. > > -- Felipe > > > > > On Wed, 2004-11-24 at 19:39, Miguel Griffa wrote: > > Well, the patch is here http://jira.codehaus.org/browse/MPXDOC-129 > > I hope some commiter likes it and adds it :) > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
