Hi Daniel,

On Mar 16, 2007, at 4:26 PM, Daniel Kulp wrote:


Vincent,

Two issues:

1)  I notice trunk of clover uses the ResourceManager.   Thus, it
probably suffers from the same problem as PMD and Checkstyle.   Thus,
the license location is probably not able to be a URL like the docs say
and would thus be a regression from 2.3.

Can you tell me more about it?

I've checked and I've noticed you add the following 3 lines to PmdReport.java:

+ locator.addSearchPath( FileResourceLoader.ID, project.getFile ().getParentFile().getAbsolutePath() );
+        locator.addSearchPath( "url", "" );
+ locator.setOutputDirectory( new File( project.getBuild ().getDirectory() ) );

What is the current if you don't have these lines (I need to understand so that I can add a test for the problem - Note that I already have a test for bundling a Clover license file in a JAR and it seems to work fine)?


2) You didn't provide a staging location and such for the vote.

What kind of staging location? Is it simply a matter of putting the plugin jar somewhere or do I need to reproduce a maven repo structure and such (and if so how)? I probably missed the discussions on this and I apologize for that.

Thanks
-Vincent

On Friday 16 March 2007 10:45, Vincent Massol wrote:
Hi,

As Mike Perham pointed out the Clover license for the release clover
plugin (ie v2.3) has expired. Thus the urgency to release version 2.4.

Here's the release notes for 2.4:

** Bug
     * [MCLOVER-45] - Excluded files should be added to compiled
sources * [MCLOVER-53] - Clover plugin installs clover instrumented
source in local repository

** Improvement
     * [MCLOVER-38] - Allow check Mojo to be overriden by a
failOnViolation parameter in the same way PMD and Checkstyle can
     * [MCLOVER-65] - Clover license has expired

Here's my +1

Thanks
-Vincent

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727    C: 508-380-7194
[EMAIL PROTECTED]
http://www.dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to