Joakim Erdfelt wrote: > -1 (conditional) > > evoking the spirit of dkulp ... > > 1) The embedded maven-core-2.0.7-uber.jar has bad LICENSE.txt and > NOTICE.txt files. > 1a) The LICENSE.txt at the root of the maven-core-2.0.7-uber.jar is for > JSch's LGPL license. not ASL. > 1b) There is no NOTICE.txt file at the root. > 1c) There is a META-INF/NOTICE.txt file, but it only mentioned > wagon-file provider. > 1d) The META-INF/MANIFEST.MF was built by me!? huh? > > Aside: With this new uber-jar setup, can we include wagon-webdav now? > > - Joakim
Another problem - the assembly in http://people.apache.org/~jvanzyl/maven-2.0.7/ is different to the assembly in http://people.apache.org/~jvanzyl/maven-2.0.7-staging-repository/ The one in the staging repo: - has unix EOLs for m2.bat, mvn.bat and m2.conf - has in the uberjar manifest: Built-By: jvanzyl Build-Jdk: 1.5.0_07 unlike the other, which has: Built-By: joakim Build-Jdk: 1.4.2_12 - has a META-INF/NOTICE.txt from maven-plugin-api instead of from wagon-file. - is missing the wagon providers! Also, the one in http://people.apache.org/~jvanzyl/maven-2.0.7/ contains some org.xml.sax and org.w3c.dom classes ... should it? The 2.0.6 release uberjar contains them too. Max.
signature.asc
Description: OpenPGP digital signature
