D/E were meant to work in cases where the - leading character might be a problem. If it's never a problem, we don't need them. If the only argument to the -P option can be something like "- myProfile" (leading dash) then we have no need for it...and the ! notation might make this even better.

-john

On May 15, 2008, at 11:40 AM, Paul Gier wrote:

2.0.x and 2.1 work the same after your change. "+" means activate and "-" means deactivate. I'm guessing it was just a typo in 2.1 that had them reversed.

What's the reason for the D: and E: syntax? Do we need these if +,-,!, can be used?


John Casey wrote:
I looked at the logic for +/- the other day (when I added E: and D:, fwiw), and the logic was backward, IIRC...I fixed it in 2.1, but it may still be broken in 2.0.x, not sure...
-john
On May 14, 2008, at 5:44 PM, Brian E. Fox wrote:
<snip>
Need to think about 1& 2 some more but:

3. There was a suggestion to allow the use of "!" to disable a profile.
So the
command line would look like: mvn -P!myProfile

This seems more intuitive than the current syntax using a dash, and I
created
MNG-3571 for it. But I'm hesitant to add it since we can already use
"-" for
this, and it looks like "mvn -P D:myProfile" was added as another
option for
disabling a profile in 2.1.

As far as I know, the - never worked so going to ! is better...I think the 2.1 deactivation should be brought in line as well...we don't need
more proliferation of changes.

-------------------------------------------------------------------- -
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---
John Casey
Committer and PMC Member, Apache Maven
mail: jdcasey at commonjava dot org
blog: http://www.ejlife.net/blogs/john
rss: http://feeds.feedburner.com/ejlife/john


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---
John Casey
Committer and PMC Member, Apache Maven
mail: jdcasey at commonjava dot org
blog: http://www.ejlife.net/blogs/john
rss: http://feeds.feedburner.com/ejlife/john


Reply via email to