I've started my second attempt to generify the API, using call hierarchy to check how collections are used in code. I still don't know how to handle this buildFromRepository method : Considering the current remote-resource-plugin releases will wail with a ClassCastException I'd like to remove the unused normalize method and define a strong typed API - the SNAPSHOT code of remote-resource plugin is ready for this. On the other side maybe it's preferable for buildFromRepository method to support this normalize process, to match the trunk.
Nicolas 2009/5/4 John Casey <jdca...@commonjava.org> > We should fix it in 2.2.x. Unless there is an actual bug, we shouldn't make > ANY code changes in the RC branch. > > > > nicolas de loof wrote: > >> Not sure to understand you well. Do you mean release 2.2.0 as is, remove >> this normalize code in 2.2.x branch and set buildFromRepository method >> signature set to List<ArtifactRepository> ?Or fix 2.2.x AND 2.2.RC >> branches >> to support the normalization process for better compatibility with >> previous >> versions of remote-resources plugin ? >> >> 2009/5/4 John Casey <jdca...@commonjava.org> >> >> Personally, I think we should fix it. We're just now doing 2.2.0-RC1, so >>> there's no reason we can't make a new release of the resources plugin >>> before >>> 2.2.1 to get this fixed. >>> >>> >>> nicolas de loof wrote: >>> >>> The commit seems to be related to Seems to be related to >>>> http://jira.codehaus.org/browse/MRRESOURCES-15 >>>> >>>> according to remote-resource plugin source in trunk the plugin uses the >>>> expected ProjectUtils.buildArtifactRepositories to build a valid >>>> List<ArtifactRepository> from a List<Repository>, and don't call >>>> the buildFromRepository with a un-normalised List<Repository>. >>>> >>>> BUT the latest stable 1.0.1 don't use this and >>>> calls mavenProjectBuilder.buildFromRepository with >>>> ${project.repositories}. >>>> >>>> Based on this, MRRESOURCES-15 seems not to be fixed in maven 2.2.x with >>>> a >>>> non-snapshot project. >>>> >>>> Should we fix the core or expect plugins to use >>>> buildArtifactRepositories >>>> builder method - and wait for a 1.0.2 release of remote-resources-plugin >>>> ? >>>> >>>> >>>> 2009/5/4 Benjamin Bentmann <benjamin.bentm...@udo.edu> >>>> >>>> nicolas de loof wrote: >>>> >>>>> >>>>> ------------------------------------------------------------------------ >>>>> >>>>> r616830 | jdcasey | 2008-01-30 19:24:41 +0100 (mer., 30 janv. 2008) | >>>>>> 1 >>>>>> line >>>>>> >>>>>> porting revId 616610 of trunk back to 2.0.x branch >>>>>> >>>>>> The commits mentioned suggest that your analysis was right and the >>>>>> code >>>>>> >>>>> in >>>>> the 2.x branches is buggy. While in the original r616610 the return >>>>> value >>>>> of >>>>> normalizeToArtifactRepositories() is used, it's not in r616830 and the >>>>> method has no side effects either. >>>>> >>>>> This naturally leads to the question, if the code in 2.x isn't >>>>> effective >>>>> anyway and nothing requires it in practice, should we should get rid of >>>>> it? >>>>> >>>>> >>>>> Benjamin >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>> For additional commands, e-mail: dev-h...@maven.apache.org >>> >>> >>> >> > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
