On 6-Aug-09, at 5:59 AM, Olivier Lamy wrote:
Hi,
Regarding trunk and reporting, I have worked on two branches (trunk
[1] and site-plugin [2] ) regarding MNG-4162
So at this stage, it works fine and without huge change in the trunk
(only new methods and change methods from private to public).
So someone else could review that or can I merge it ?
I will take a look and I know that Benjamin will as well.
At this point is the configuration of the site plugin entirely
encapsulated in the site plugin. There is no reliance on elements in
the POM?
The aggregation still needs work on in the trunk so you just have a
single run of the site plugin working?
In fact, I'd like to merge it before my vacation (tomorrow evening)
because I'm a little afraid about two weeks of vacations if some major
changes/refactoring are applied to trunk :-)
That's not enough time but I think we can make sure it's merged before
you get back. If the site plugin is entirely encapsulated we'll make
it run with trunk. We need to check all the integration tests, and
it's pretty important for me that m2eclipse is not impacted by the
changes.
IMHO, it's important to have site working with trunk because it's big
part of the maven project.
I agree and it looks like you got us there. It just needs to be
reviewed and a day is not long enough.
Thanks,
--
Olivier
[1] https://svn.apache.org/repos/asf/maven/components/branches/MNG-4162/
[2]
https://svn.apache.org/repos/asf/maven/plugins/branches/maven-site-plugin-3.x/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
the course of true love never did run smooth ...
-- Shakespeare
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
