On 6-Aug-09, at 8:31 AM, Olivier Lamy wrote:
2009/8/6 Jason van Zyl <[email protected]>:
On 6-Aug-09, at 6:50 AM, Olivier Lamy wrote:
2009/8/6 Jason van Zyl <[email protected]>:
On 6-Aug-09, at 5:59 AM, Olivier Lamy wrote:
Hi,
Regarding trunk and reporting, I have worked on two branches
(trunk
[1] and site-plugin [2] ) regarding MNG-4162
So at this stage, it works fine and without huge change in the
trunk
(only new methods and change methods from private to public).
So someone else could review that or can I merge it ?
I will take a look and I know that Benjamin will as well.
Great !
At this point is the configuration of the site plugin entirely
encapsulated
in the site plugin. There is no reliance on elements in the POM?
I don't follow you here ?
I only use reporting section to know which report to execute.
Yah, we had a misunderstanding then. The configuration for the site
plugin
must be completely contained within the site plugin configuration.
Arf.
In fact I didn't want to force users to do a so big change.
IMHO If we want people migrate to this version, it will be difficult
with such change.
What about handle this but with a warning log saying it's deprecated
blabla ?
We will, but the new plugin has to be completely self-contained. In
version 4.0.0 we'll do some warnings and even map the POM elements
into the new maven-site-plugin configuration where the elements exist
but the new version of the maven-site-plugin has to be self-contained.
All reporting plugins will be the same. If the plugin works in a self-
contained way it will definitely work the old way. In subsequent
versions of the POM the maven-site-plugin will have no special place
in the POM, opening the door for entirely new reporting systems.
There is not going to be any reporting element in the POM because
it is
completely maven-site-plugin specific and that's exactly what I
don't want.
Put the reporting element or however you want to configure the site
plugin
in the site plugin. The reporting element in the POM is going to go
away in
favor of reporting systems having complete self-containment. Then all
reporting mechanism will be on equal footing in 3.x.
So that's the first requirement, and I didn't communicate that well
enough.
The aggregation still needs work on in the trunk so you just have a
single
run of the site plugin working?
Yes (I will have a look today evening)
In fact, I'd like to merge it before my vacation (tomorrow
evening)
because I'm a little afraid about two weeks of vacations if some
major
changes/refactoring are applied to trunk :-)
That's not enough time but I think we can make sure it's merged
before
you
get back. If the site plugin is entirely encapsulated we'll make
it run
with
trunk. We need to check all the integration tests, and it's pretty
important
for me that m2eclipse is not impacted by the changes.
Just have a look at what I have touched (only new methods)
I'll take a look but is there anything reporting specific? i.e. No
report
classes can be present in the core.
No reporting specific.
I can take a look tomorrow later in the day, but I don't have any
time until
then and it I think some self-containment work still needs to be
done.
IMHO, it's important to have site working with trunk because
it's big
part of the maven project.
I agree and it looks like you got us there. It just needs to be
reviewed
and
a day is not long enough.
Agree (I can go on beach in peace :-) ).
Thanks,
--
Olivier
[1] https://svn.apache.org/repos/asf/maven/components/branches/MNG-4162/
[2]
https://svn.apache.org/repos/asf/maven/plugins/branches/maven-site-plugin-3.x/
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
the course of true love never did run smooth ...
-- Shakespeare
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Olivier
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
A language that doesn’t affect the way you think about programming
is not
worth knowing.
-— Alan Perlis
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Olivier
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder, Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/SonatypeNexus
http://twitter.com/SonatypeM2E
----------------------------------------------------------
What matters is not ideas, but the people who have them. Good people
can fix bad ideas, but good ideas can't save bad people.
-- Paul Graham
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
