Yeah but as release:perform forks a build the cli arguments would be ignored... or have I missed something in the specifics of this patch
On 1 February 2011 20:07, John Casey <jdca...@commonjava.org> wrote: > FWIW, I'd really love to see us limit the use of command-line parameters > that change the way the build runs. I understand this can be very useful > during debugging (if you're not able run a particular single test in an IDE > for some reason, as one example), but the danger represented by specifying > things like: > > mvn -Dmaven.test.skip=true release:perform > > is something we should consider. It's not that I want to force everyone to > run their tests (though they should), but that I'd prefer to see the release > (and deploy?) processes as forbidding command-line options that can mutate > the standard build. Otherwise, you can make the argument that the release is > unreproducible. > > On 2/1/11 3:00 PM, Kristian Rosenvold wrote: >> >> I have looked at the patch diffs and it looks really great, one of the >> better patches I've seen in the issue trackers ! >> >> We had a quick chat about this patch on irc and we figured we could take >> this patch for 3.0.x. >> >> One thing we would like though, is to be able to specify multiple >> exclusions, not just one plugin/execution. Any chance you could fix >> that ? >> >> As for the documentation, that would be something >> like https://svn.apache.org/repos/asf/maven/site/trunk >> >> and the document >> >> src/site/apt/guides/mini/guide-configuring-maven.apt >> >> Sorry for not replying immediately; been busy preparing >> my trip to the alps tomorrow ;) >> >> Kristian >> >> >> ti., 01.02.2011 kl. 09.16 +0530, skrev Kalyan Akella: >>> >>> Hi, >>> >>> Any updates on the patch. Did it apply cleanly ? Any comments, changes ?? >>> >>> Sincere Regards, >>> Kalyan C. Akella >>> >>> On Sat, Jan 29, 2011 at 8:01 AM, Kalyan >>> Akella<kalyan.ake...@gmail.com>wrote: >>> >>>> Hi, >>>> >>>> Thank you for the comments. I updated the issue, >>>> http://jira.codehaus.org/browse/MNG-3321 with the modified patches. >>>> Regarding your point about documentation, will you please point me to >>>> the >>>> exact location where I should include the usage instructions for this >>>> feature and other info (perhaps a wiki ?). >>>> >>>> >>>> Sincere Regards, >>>> Kalyan C. Akella >>>> >>>> On Fri, Jan 28, 2011 at 12:55 PM, Kristian Rosenvold< >>>> kristian.rosenv...@gmail.com> wrote: >>>> >>>>> Thanks for the patch, which looks good. I added some comments to the >>>>> issue, http://jira.codehaus.org/browse/MNG-3321 >>>>> >>>>> >>>>> Kristian >>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>>> >>>>> >>>> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> > > -- > John Casey > Developer, PMC Member - Apache Maven (http://maven.apache.org) > Blog: http://www.johnofalltrades.name/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
