So the technical work was done implementing this but no where in the issue does it describe why this feature is useful.
This fundamentally changes the behaviour of the lifecycle and the example listed in the issue is skipping tests. Some explanation of why this is good would be nice, there's nothing about the reasoning of the feature in the issue. Possibly something like: - As a user I would like to skip the test phase locally, and only from the command line so it's easier while I experiment putting new test features in place. But I would like to guarantee that these can only be done from the command line and never in the presence of the release plugin so that skipping phases is not done inadvertently during a release. The second case in a issue doesn't strike me as useful without an explanation, to run to the install phase but not package the JAR? I think a fundamental alteration of behaviour requires an explanation of reasoning. I believe that is reasonable. It initially strikes me as a potentially bad idea. Maybe you talked about the reasoning in IRC, which I think is perfectly fine, just toss the discussion or salient points of the reasoning into the issue. On Feb 1, 2011, at 3:00 PM, Kristian Rosenvold wrote: > I have looked at the patch diffs and it looks really great, one of the > better patches I've seen in the issue trackers ! > > We had a quick chat about this patch on irc and we figured we could take > this patch for 3.0.x. > > One thing we would like though, is to be able to specify multiple > exclusions, not just one plugin/execution. Any chance you could fix > that ? > > As for the documentation, that would be something > like https://svn.apache.org/repos/asf/maven/site/trunk > > and the document > > src/site/apt/guides/mini/guide-configuring-maven.apt > > Sorry for not replying immediately; been busy preparing > my trip to the alps tomorrow ;) > > Kristian > > > ti., 01.02.2011 kl. 09.16 +0530, skrev Kalyan Akella: >> Hi, >> >> Any updates on the patch. Did it apply cleanly ? Any comments, changes ?? >> >> Sincere Regards, >> Kalyan C. Akella >> >> On Sat, Jan 29, 2011 at 8:01 AM, Kalyan Akella >> <kalyan.ake...@gmail.com>wrote: >> >>> Hi, >>> >>> Thank you for the comments. I updated the issue, >>> http://jira.codehaus.org/browse/MNG-3321 with the modified patches. >>> Regarding your point about documentation, will you please point me to the >>> exact location where I should include the usage instructions for this >>> feature and other info (perhaps a wiki ?). >>> >>> >>> Sincere Regards, >>> Kalyan C. Akella >>> >>> On Fri, Jan 28, 2011 at 12:55 PM, Kristian Rosenvold < >>> kristian.rosenv...@gmail.com> wrote: >>> >>>> Thanks for the patch, which looks good. I added some comments to the >>>> issue, http://jira.codehaus.org/browse/MNG-3321 >>>> >>>> >>>> Kristian >>>> >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >>>> For additional commands, e-mail: dev-h...@maven.apache.org >>>> >>>> >>> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl --------------------------------------------------------- First, the taking in of scattered particulars under one Idea, so that everyone understands what is being talked about ... Second, the separation of the Idea into parts, by dividing it at the joints, as nature directs, not breaking any limb in half as a bad carver might. -- Plato, Phaedrus (Notes on the Synthesis of Form by C. Alexander)
