they are fine. if they pass for plexus, then they are in the tck - Stephen
--- Sent from my Android phone, so random spelling mistakes, random nonsense words and other nonsense are a direct result of using swype to type on the screen On 24 May 2011 18:53, "Brian Demers" <[email protected]> wrote: > Not exactly clean room, but I have a feeling a lot of test cases could be > copied from the given commons-* projects such as: > http://svn.apache.org/viewvc/commons/proper/io/trunk/src/test/java/org/apache/commons/io/FileUtilsTestCase.java?view=markup > > This should work for methods with the same signatures. (it would help with > the coverage anyway) > > > On Tue, May 24, 2011 at 12:25 PM, Kristian Rosenvold < > [email protected]> wrote: > >> >> > Hey if we could just copy the plexus source code in tree we wouldn't >> > be doing this would we? If you have the provenance of the code and it >> > is ASL license friendly, then fine copy & paste. >> > >> >> That'd really be depending on the overall usage of a shim layer, >> wouldn't it ? I think a shim makes sense for the stuff mentioned in >> http://jira.codehaus.org/browse/PLXUTILS-21 other than that I think it >> makes sense to rework the dependencies or keep them as-is. Plexus-utils >> is a bit of a flea market functionality wise and some of it may be >> totally unused for all I know. >> >> But if the intention of the shim is to ensure/validate compatibility it >> will often just delegate directly to another method. So if I was >> upgrading to the shim I'd almost certainly inline the method invocations >> so I'd just be left with clean dependencies on the real implementations. >> So in this respect I could just use the shim as a transitional measure. >> >> >> Kristian >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >>
