On Nov 15, 2012, at 8:40 AM, Gary Gregory <[email protected]> wrote:

> On Thu, Nov 15, 2012 at 8:30 AM, Jason van Zyl <[email protected]> wrote:
> 
>> 
>> On Nov 15, 2012, at 8:18 AM, Olivier Lamy <[email protected]> wrote:
>> 
>>> Hi,
>>> Currently logger for all mojos is the DefaultPluginManager logger.
>>> So it's a bit hard to have filtering per plugin (i.e. only compiler in
>>> debug etc..)
>>> 
>>> So I'd like to change that to be able to customize mojo logging.
>>> My first is idea is mojo with logger name ${groupId}:${artifactId} (ie
>>> org.apache.maven.plugins:maven-clean-plugin) so if you only want debug
>>> for compiler put logger org.apache.maven.plugins:maven-compiler-plugin
>>> to debug.
>>> 
>>> Makes sense ?
>>> 
>> 
>> Why not use the standard way of using the class name of the plugin and
>> using standard techniques for filtering?
>> 
> 
> If you always use "." as the separator (not ":"), you will be able to use
> most logging framework's hierarchical logging features.
> 

Right, another reason to use something standard. Logback does not recognize the 
":" for hierarchies.

So would you agree that using class names accepted as a best practice and does 
not limit any sort of filtering?

> Gary
> 
> 
>> 
>>> The code to change is here:
>>> 
>> https://github.com/olamy/maven-3/blob/log4j2/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java#L445
>>> 
>>> WDYT ?
>>> 
>>> Thanks
>>> --
>>> Olivier Lamy
>>> Talend: http://coders.talend.com
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>> 
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>> 
>> 
>> Thanks,
>> 
>> Jason
>> 
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder & CTO, Sonatype
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>> 
>> I never make the mistake of arguing with people for whose opinions I have
>> no respect.
>> 
>> -- Edward Gibbon
>> 
>> 
>> 
>> 
>> 
>> 
> 
> 
> -- 
> E-Mail: [email protected] | [email protected]
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder & CTO, Sonatype
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------

believe nothing, no matter where you read it,
or who has said it,
not even if i have said it,
unless it agrees with your own reason
and your own common sense.

 -- Buddha





Reply via email to