----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review30283 -----------------------------------------------------------
src/slave/container/isolators/cpu/posix.hpp <https://reviews.apache.org/r/16150/#comment57972> I'm not convinced that we need subclasses of PosixIsolatorProcess. Any reason we can't do both CPU and Mem together for now? I don't see any problem since we'll be merging the ResourceStatistics anyway. It's less code this way too. At the very least, the shared code in each usage should be factored out (and see the comment about trying to use os::pstree). - Benjamin Hindman On Dec. 11, 2013, 4:09 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16150/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 4:09 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Isolators perform isolator for the MesosContainerizer > > Isolator interface and implementations of Posix CPU and Mem isolators (no > isolation, just usage()) > > > Diffs > ----- > > src/slave/container/isolator.hpp PRE-CREATION > src/slave/container/isolator.cpp PRE-CREATION > src/slave/container/isolators/cpu/posix.hpp PRE-CREATION > src/slave/container/isolators/cpu/posix.cpp PRE-CREATION > src/slave/container/isolators/mem/posix.hpp PRE-CREATION > src/slave/container/isolators/mem/posix.cpp PRE-CREATION > src/slave/container/isolators/posix.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16150/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
