> On Jan. 23, 2014, 6:39 p.m., Niklas Nielsen wrote: > > src/slave/container/isolator.hpp, line 108 > > <https://reviews.apache.org/r/16150/diff/4/?file=425489#file425489line108> > > > > This initialize overshadows initialize in Process. Can use resolve this > > with 'using process::ProcessBase::initialize;'?
This won't overshadow process::ProcessBase::initialize()? - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review32553 ----------------------------------------------------------- On Jan. 21, 2014, 7:34 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16150/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2014, 7:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Isolators perform isolator for the MesosContainerizer > > Isolator interface and implementations of Posix CPU and Mem isolators (no > isolation, just usage()) > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/container/isolator.hpp PRE-CREATION > src/slave/container/isolator.cpp PRE-CREATION > src/slave/container/isolators/posix.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16150/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
