-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16150/#review32553
-----------------------------------------------------------

Ship it!



src/Makefile.am
<https://reviews.apache.org/r/16150/#comment61433>

    Align '\''s



src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61434>

    Can you comment this call too?



src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61435>

    This one.



src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61436>

    This one.



src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61437>

    And this one.



src/slave/container/isolator.hpp
<https://reviews.apache.org/r/16150/#comment61438>

    This initialize overshadows initialize in Process. Can use resolve this 
with 'using process::ProcessBase::initialize;'?


- Niklas Nielsen


On Jan. 21, 2014, 11:34 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16150/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2014, 11:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas 
> Nielsen, samya, and Jason Dusek.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Isolators perform isolator for the MesosContainerizer
> 
> Isolator interface and implementations of Posix CPU and Mem isolators (no 
> isolation, just usage())
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 
>   src/slave/container/isolator.hpp PRE-CREATION 
>   src/slave/container/isolator.cpp PRE-CREATION 
>   src/slave/container/isolators/posix.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/16150/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to