My concern with adding .gitignore to the repo is that typically I have additional things I want to ignore that are specific to me (e.g., eclipse project files). Adding those to the .gitignore would should up in my git diff and git status if .gitignore is a tracked file.
On Fri, Jan 17, 2014 at 10:25 AM, Dave Lester <d...@ischool.berkeley.edu>wrote: > Hi Ben, > > I see that you've already submitted this review > https://reviews.apache.org/r/17001/, but could answer my question above? > > It's possible that you didn't receive it because I sent it through my > Twitter email acct which is prone to being caught by email filters. > > Thanks, > Dave > > > > On Thu, Jan 16, 2014 at 4:31 PM, Dave Lester <dles...@twitter.com> wrote: > > > Hi Ben, > > > > Is there a previous thread you can point us to? I'd like to understand > the > > concern more. For most users, I think having a .gitignore file is the > > most-convenient way to manage your code in development. If people want to > > see ignored files, it's easy to run: > > > > git status --ignored > > > > What do you think? > > > > Dave > > > > On Thu, Jan 16, 2014 at 4:21 PM, Benjamin Hindman < > b...@eecs.berkeley.edu>wrote: > > > >> People have asked about this before. Some people don't want .gitignore > >> files because they like to see everything that's in their directories, > >> including generated files so they have a better idea of when something > was > >> supposed to get generated but didn't, etc. > >> > >> In the past people have simply added their own .gitignore (adding > >> '.gitignore' to it as well so it ignores itself). Someone once proposed > >> committing a .gitignore-template (or something similarly named) that a > >> developer can copy to .gitignore if they choose to (but this doesn't > force > >> people that don't want .gitignore to use it). > >> > >> > >> On Thu, Jan 16, 2014 at 3:11 PM, Dave Lester <d...@ischool.berkeley.edu > >> >wrote: > >> > >> > This makes sense to me. > >> > > >> > > >> > On Thu, Jan 16, 2014 at 2:08 PM, Charlie Carson <ccar...@twitter.com> > >> > wrote: > >> > > >> > > Hey guys, is it good / bad / different if we were to add the files > >> that > >> > > automake generates and to put them into appropriate .gitignore files > >> and > >> > > check those in? > >> > > > >> > > I'm new to mesos dev, so probably missing context, but wanted to > >> double > >> > > check instead of just working around it for myself. > >> > > > >> > > if it does make sense then I'd be happy to create the JIRA and > initial > >> > CR. > >> > > > >> > > thanks, > >> > > cc > >> > > > >> > > >> > > > > > > > > -- > > @davelester > > Open Source Advocate | Twitter, Inc > > >
