----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17767/#review33744 -----------------------------------------------------------
Ship it! src/log/tool/benchmark.cpp <https://reviews.apache.org/r/17767/#comment63377> You should mention what is the expected format of the trace file. src/log/tool/benchmark.cpp <https://reviews.apache.org/r/17767/#comment63378> Can you explain a bit more on what the tool actually does? Either here or as a comment in this file? src/log/tool/benchmark.cpp <https://reviews.apache.org/r/17767/#comment63379> Maybe instead of "vector<Bytes> sizes" you could do "vector<string> data" and compute the data while you are reading the trace file. That way you don't spend time constructing data while looping here. Not a big deal though. src/log/tool/benchmark.cpp <https://reviews.apache.org/r/17767/#comment63380> How about including the units? cout << sizes[i].bytes() << " bytes " << durations[i].ms() << " ms " << times[i].secs() << " secs" << endl; - Vinod Kone On Feb. 6, 2014, 12:20 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17767/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 12:20 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. Currently, only type 'zero' and 'one' are supported. I will add > 'random' soon. > > > Diffs > ----- > > src/Makefile.am c307068 > src/log/main.cpp c37dd6f > src/log/tool/benchmark.hpp PRE-CREATION > src/log/tool/benchmark.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17767/diff/ > > > Testing > ------- > > make check > > tested on command line. > > > Thanks, > > Jie Yu > >
