> On Feb. 6, 2014, 12:34 a.m., Vinod Kone wrote: > > src/log/tool/benchmark.cpp, lines 198-202 > > <https://reviews.apache.org/r/17767/diff/1/?file=470420#file470420line198> > > > > Maybe instead of "vector<Bytes> sizes" you could do "vector<string> > > data" and compute the data while you are reading the trace file. > > > > That way you don't spend time constructing data while looping here. > > > > Not a big deal though.
Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17767/#review33744 ----------------------------------------------------------- On Feb. 6, 2014, 12:20 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17767/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 12:20 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. Currently, only type 'zero' and 'one' are supported. I will add > 'random' soon. > > > Diffs > ----- > > src/Makefile.am c307068 > src/log/main.cpp c37dd6f > src/log/tool/benchmark.hpp PRE-CREATION > src/log/tool/benchmark.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17767/diff/ > > > Testing > ------- > > make check > > tested on command line. > > > Thanks, > > Jie Yu > >
