> On Feb. 6, 2014, 10:25 p.m., Vinod Kone wrote: > > src/log/tool/benchmark.cpp, lines 253-255 > > <https://reviews.apache.org/r/17767/diff/3/?file=471128#file471128line253> > > > > Sorry for not catching this earlier, but can you make the log line more > > readable? > > > > output << "Time: " << timestamps[i] << " " > > << "Appended " << sizes[i].bytes() << " bytes " > > << "in " << durations[i].ms() << " ms" << endl; > > > > Also consider printing "timestamps[i]" as an epoch of > > seconds/milliseconds to make it easy to crunch this data. > > > > Jie Yu wrote: > Choose to do this: > > output << timestamps[i] > << " Appended " << sizes[i].bytes() << " bytes" > << " in " << durations[i].ms() << " ms" << endl; > > which prints like the following: > > 2014-02-06 22:00:32.721331968+00:00 Appended 4717 bytes in 10.9142 ms
BTW: Using "an epoch of seconds/milliseconds" will print a double like 1.3xxxxE9, which I don't like:) - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17767/#review33852 ----------------------------------------------------------- On Feb. 6, 2014, 10:07 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17767/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 10:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. Currently, only type 'zero' and 'one' are supported. I will add > 'random' soon. > > > Diffs > ----- > > src/Makefile.am c307068 > src/log/main.cpp c37dd6f > src/log/tool/benchmark.hpp PRE-CREATION > src/log/tool/benchmark.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17767/diff/ > > > Testing > ------- > > make check > > tested on command line. > > > Thanks, > > Jie Yu > >
