----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review33899 -----------------------------------------------------------
Ship it! src/slave/containerizer/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment63615> I thought we were going for INFO here because it's expected case. Also, you might want to pull down the comment inside the if loop. src/slave/containerizer/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment63616> Maybe include the pid and container id? src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63617> ditto. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63619> Much cleaner! - Vinod Kone On Feb. 7, 2014, 3:36 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 3:36 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/slave/containerizer/cgroups_launcher.hpp PRE-CREATION > src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION > src/slave/containerizer/launcher.hpp PRE-CREATION > src/slave/containerizer/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
