----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review33857 -----------------------------------------------------------
src/slave/containerizer/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment63494> A better error message? src/slave/containerizer/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment63496> maybe add why its needed. src/slave/containerizer/cgroups_launcher.cpp <https://reviews.apache.org/r/16149/#comment63497> make it consistent with subprocess implementation. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63500> ditto. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63483> This should be containsValue()? src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63501> new line. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63503> same line. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63504> s/;// src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63520> Rewrite this as discussed offline. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63518> move the dequeue inside the loop below? traverse the entire tree first before moving on to the next tree. consider having a kill(ProcessTree) function and doing to recursively. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63506> new line. src/slave/containerizer/launcher.cpp <https://reviews.apache.org/r/16149/#comment63507> include container id. - Vinod Kone On Feb. 6, 2014, 5:35 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 5:35 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/slave/containerizer/cgroups_launcher.hpp PRE-CREATION > src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION > src/slave/containerizer/launcher.hpp PRE-CREATION > src/slave/containerizer/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
