> On Jan. 29, 2014, 5:52 p.m., Niklas Nielsen wrote: > > src/slave/containerizer/cgroups_launcher.cpp, line 259 > > <https://reviews.apache.org/r/16149/diff/7/?file=451161#file451161line259> > > > > GCC 4.8.2 fails here; error: ignoring return value of ‘ssize_t > > write(int, const void*, size_t)’, declared with attribute > > warn_unused_result [-Werror=unused-result] > > > > Same thing applies for mesos_containerizer.cpp:231
Sorry about that, it wasn't complaining on my 4.2.1 so I missed it but you're right. Changed to ignore the return values. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16149/#review33125 ----------------------------------------------------------- On Jan. 27, 2014, 3:02 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16149/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 3:02 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Launcher interface and MesosLauncher to support MesosContainerizers. > > Launchers handle the lifecycle of the executor process (and descendants). > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/containerizer/cgroups_launcher.hpp PRE-CREATION > src/slave/containerizer/cgroups_launcher.cpp PRE-CREATION > src/slave/containerizer/launcher.hpp PRE-CREATION > src/slave/containerizer/launcher.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16149/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
