----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review36075 -----------------------------------------------------------
src/examples/python/test_containerizer.py <https://reviews.apache.org/r/17567/#comment66953> How about making this implementation optional/configurable? We should eventually be exercising both call paths :) Maybe not now, but in a sequent review. src/slave/containerizer/pluggable_containerizer.hpp <https://reviews.apache.org/r/17567/#comment66954> Think this comment is obsolete ;) src/slave/containerizer/pluggable_containerizer.hpp <https://reviews.apache.org/r/17567/#comment66955> s/executor/container/? I know the lines are a bit blurry here. src/slave/containerizer/pluggable_containerizer.hpp <https://reviews.apache.org/r/17567/#comment66956> s/external/pluggable/ and the rest of the review? Just want to get the terms straight :) src/slave/containerizer/pluggable_containerizer.hpp <https://reviews.apache.org/r/17567/#comment66958> Can you wrap input to next line? src/slave/containerizer/pluggable_containerizer.hpp <https://reviews.apache.org/r/17567/#comment66961> s/commandSupported/isCommandSupported/? You are using 'get' in getStatus() and getResult() src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment66975> You are using 2 indents in wrapping from .onAny(.. to next line in the rest of the file src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment66972> 2 indents. src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment66971> The wrapping looks odd - I might be wrong. src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment66970> s/pogram/program/ src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment66965> Kill newline src/slave/containerizer/pluggable_containerizer.cpp <https://reviews.apache.org/r/17567/#comment66966> s/External/Pluggable/? src/tests/pluggable_containerizer_test.cpp <https://reviews.apache.org/r/17567/#comment66963> I think this comment is obsolete. - Niklas Nielsen On Feb. 27, 2014, 5:23 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 5:23 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes, > Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called pluggable containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). Few calls have internal fall-back implementations > such as wait(), destroy() and usage(). > > The protocol for the interactions with the external program > is as follows: > > COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO > > launch (ContainerID, --mesos-executor, <path>) < TaskInfo > PluggableStatus > update (ContainerID) < ResourceArray > PluggableStatus > usage (ContainerID) > ResourceStatistics > wait (ContainerID) > PluggableTermination > destroy (ContainerID) > PluggableStatus > > When protocol buffers need to be provided, the Mesos side of > the pluggable containerizer will serialize the protos on stdin > and vice-versa for reading protos on stdout as drafted in the > above scheme. > > > Diffs > ----- > > configure.ac a8bc8a8 > include/mesos/mesos.proto 37f8a7f > src/Makefile.am 61d832b > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.cpp d0a1023 > src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION > src/slave/flags.hpp e4d98a5 > src/tests/pluggable_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > >
