-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17567/#review36654
-----------------------------------------------------------
Bad patch!
Reviews applied: [18595, 18594, 18311, 18403, 17567]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
[enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with
attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute
warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This
file includes at least one deprecated or antiquated header which may be removed
without further notice at a future date. Please use a non-deprecated interface
with equivalent functionality instead. For a listing of replacement headers and
interfaces, consult the file backward_warning.h. To disable this warning use
-Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous
definition
In file included from src/tests/process_tests.cpp:12:0:
./include/process/collect.hpp: In function 'process::Future<process::Future<T>
> process::await(const process::Future<T>&, const Option<process::Timeout>&)
[with T = int]':
src/tests/process_tests.cpp:1085:57: instantiated from here
./include/process/collect.hpp:340:51: error: no matching function for call to
'bind(<unresolved overloaded function type>, const process::Future<int>&)'
./include/process/collect.hpp:340:51: note: candidates are:
/usr/include/c++/4.6/tr1/functional:1372:5: note: template<class _Result, class
_Functor, class ... _ArgTypes> std::tr1::_Bind_result<_Result, typename
std::tr1::_Maybe_wrap_member_pointer<_Functor>::type(_ArgTypes ...)>
std::tr1::bind(_Functor, _ArgTypes ...)
/usr/include/c++/4.6/tr1/functional:1359:5: note: template<class _Functor,
class ... _ArgTypes> std::tr1::_Bind<typename
std::tr1::_Maybe_wrap_member_pointer<_Functor>::type(_ArgTypes ...)>
std::tr1::bind(_Functor, _ArgTypes ...)
make[5]: *** [tests-process_tests.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [check-am] Error 2
make[3]: *** [check-recursive] Error 1
make[2]: *** [check-recursive] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 10, 2014, 4:10 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17567/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 4:10 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes,
> Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-816
> https://issues.apache.org/jira/browse/MESOS-816
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This patch adds the so-called pluggable containerizer. This
> containerizer delegates all containerizer calls directly to
> an external, pluggable containerizer program (which can be
> specified on start-up). Few calls have internal fall-back
> implementations such as wait(), destroy() and usage().
>
> The protocol for the interactions with the external program
> is as follows:
>
> COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO
>
> launch (ContainerID, --mesos-executor, <path>) < TaskInfo > PluggableStatus
> update (ContainerID) < ResourceArray > PluggableStatus
> usage (ContainerID) > ResourceStatistics
> wait (ContainerID) > PluggableTermination
> destroy (ContainerID) > PluggableStatus
>
> When protocol buffers need to be provided, the Mesos side of
> the pluggable containerizer implementation will serialize the
> protos on stdin and vice-versa for reading protos on stdout as
> drafted in the above scheme.
>
>
> Diffs
> -----
>
> configure.ac 390f11b
> include/mesos/mesos.proto 37f8a7f
> src/Makefile.am 384b312
> src/examples/python/test-containerizer.in PRE-CREATION
> src/examples/python/test_containerizer.py PRE-CREATION
> src/slave/containerizer/containerizer.cpp d0a1023
> src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION
> src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION
> src/slave/flags.hpp c9a627b
> src/tests/pluggable_containerizer_test.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17567/diff/
>
>
> Testing
> -------
>
> make check and functional testing.
>
>
> Thanks,
>
> Till Toenshoff
>
>
