> On March 4, 2014, 2:25 a.m., Niklas Nielsen wrote: > > src/slave/containerizer/pluggable_containerizer.hpp, lines 216-218 > > <https://reviews.apache.org/r/17567/diff/8/?file=506585#file506585line216> > > > > s/commandSupported/isCommandSupported/? You are using 'get' in > > getStatus() and getResult()
As we dont seem to like "get"-getters, both getStatus and getResult have been renamed to have e unified style. > On March 4, 2014, 2:25 a.m., Niklas Nielsen wrote: > > src/slave/containerizer/pluggable_containerizer.cpp, lines 774-775 > > <https://reviews.apache.org/r/17567/diff/8/?file=506586#file506586line774> > > > > The wrapping looks odd - I might be wrong. Yeah, that was odd. Fixed it. > On March 4, 2014, 2:25 a.m., Niklas Nielsen wrote: > > src/slave/containerizer/pluggable_containerizer.cpp, line 1214 > > <https://reviews.apache.org/r/17567/diff/8/?file=506586#file506586line1214> > > > > s/External/Pluggable/? In my latest version, I tried to unify the wording. Whenever the user is addressed, it is "pluggable containerizer". Whenever this wording could be misleading within the comments, I enhanced the term towards "external, pluggable containerizer". For example: // Additionally to the optional external destroy-command, we need to // terminate the external, pluggable containerizer process. terminate(containerId); > On March 4, 2014, 2:25 a.m., Niklas Nielsen wrote: > > src/examples/python/test_containerizer.py, lines 88-108 > > <https://reviews.apache.org/r/17567/diff/8/?file=506583#file506583line88> > > > > How about making this implementation optional/configurable? > > We should eventually be exercising both call paths :) > > Maybe not now, but in a sequent review. Very good point and on my todo-list once this iteration of the pluggable-containerizer has landed. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review36075 ----------------------------------------------------------- On March 4, 2014, 5:46 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 5:46 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes, > Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called pluggable containerizer. This > containerizer delegates all containerizer calls directly to > an external, pluggable containerizer program (which can be > specified on start-up). Few calls have internal fall-back > implementations such as wait(), destroy() and usage(). > > The protocol for the interactions with the external program > is as follows: > > COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO > > launch (ContainerID, --mesos-executor, <path>) < TaskInfo > PluggableStatus > update (ContainerID) < ResourceArray > PluggableStatus > usage (ContainerID) > ResourceStatistics > wait (ContainerID) > PluggableTermination > destroy (ContainerID) > PluggableStatus > > When protocol buffers need to be provided, the Mesos side of > the pluggable containerizer implementation will serialize the > protos on stdin and vice-versa for reading protos on stdout as > drafted in the above scheme. > > > Diffs > ----- > > configure.ac a84b960 > include/mesos/mesos.proto 37f8a7f > src/Makefile.am 61d832b > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.cpp d0a1023 > src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION > src/slave/flags.hpp e4d98a5 > src/tests/pluggable_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > >
