> On March 19, 2014, 6:39 p.m., Ben Mahler wrote: > > src/master/registrar.hpp, line 42 > > <https://reviews.apache.org/r/19372/diff/5/?file=528688#file528688line42> > > > > Why is this no longer templated? > > > > I can envision us overloading our Registrar apply() call based on the > > type of Operation, as we add more keys outside the Registry: > > > > Future<bool> apply(Owned<Operation<Registry> > operation); > > Future<bool> apply(Owned<Operation<Reservations> > operation); > > Future<bool> apply(Owned<Operation<Repairs> > operation); > > Benjamin Hindman wrote: > IMHO it seems easy enough to add this back in later, and simpler to read > and understand right now without it. When we do add operations on multiple > keys we might even consider calling it something other than the Registrar too > as it becomes more of an abstraction for performing operations in batch on > state variables. ;)
Ok I thought this registry is a high level concept like "Windows Registry" and new data types are put inside. I know that the underlying storage supports multiple variables but at least the Registrar only works with the "Registry". Going forward will it be multiple instances of the Registrar with whatever the new name is, whether or not itself templatized, or have a single instance of it handle all the variables/keys? It's not clear to me but can we refactor then? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19372/#review37850 ----------------------------------------------------------- On March 19, 2014, 5:12 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19372/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 5:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1112 > https://issues.apache.org/jira/browse/MESOS-1112 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > > Diff: https://reviews.apache.org/r/19372/diff/ > > > Testing > ------- > > make check GTEST_FILTER=*Registrar* > > > Thanks, > > Jiang Yan Xu > >
