----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19372/#review37986 -----------------------------------------------------------
Ship it! Looks good Yan! src/master/master.hpp <https://reviews.apache.org/r/19372/#comment69863> My fault, can you add a "// Mutation." comment here? src/master/registrar.hpp <https://reviews.apache.org/r/19372/#comment69864> Can you kill these two lines? src/master/registrar.hpp <https://reviews.apache.org/r/19372/#comment69867> "Applies an operation on the Registry." src/master/registrar.cpp <https://reviews.apache.org/r/19372/#comment69868> My fault, can you add a "// Mutation." comment here? - Ben Mahler On March 20, 2014, 7:41 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19372/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 7:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1112 > https://issues.apache.org/jira/browse/MESOS-1112 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > > Diff: https://reviews.apache.org/r/19372/diff/ > > > Testing > ------- > > make check GTEST_FILTER=*Registrar* > > > Thanks, > > Jiang Yan Xu > >
