> On March 19, 2014, 4:05 p.m., Dominic Hamon wrote: > > src/master/master.cpp, line 3234 > > <https://reviews.apache.org/r/19372/diff/4/?file=528499#file528499line3234> > > > > i find this more readable: > > > > if (strict) { > > return Error("..."); > > } > > return false; > > Ben Mahler wrote: > Please revert this per the comments on: > https://reviews.apache.org/r/19085/ > > I would like us to keep the distinction between 'strict' and 'non-strict' > very explicit in the code.
Ok reverted. > On March 19, 2014, 4:05 p.m., Dominic Hamon wrote: > > src/master/registrar.cpp, line 438 > > <https://reviews.apache.org/r/19372/diff/4/?file=528501#file528501line438> > > > > it's a shame you have to copy the entire operations deque here to be > > able to clear it before the store completes. The only way around it i can > > think of is to track the last store position and only apply from there > > until the store completes, but that's hairy. Maybe you can think of > > something else. > > > > Could you at least name this (or the member variable) differently to > > avoid shadowing the member variable? > > Jiang Yan Xu wrote: > Yeah I am going to do some benchmark next to determine whether/how to > optimize the registrar. > > Ben Mahler wrote: > Keep in mind we're copying a deque of *pointers* once per write batch, > it's likely not a problem so please measure first! > True :) - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19372/#review37819 ----------------------------------------------------------- On March 19, 2014, 5:12 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19372/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 5:12 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1112 > https://issues.apache.org/jira/browse/MESOS-1112 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 0c7c5204c31087f12c4e98028f90c1b941eab7c7 > src/master/master.cpp 6da776699beb6f449e8160dcb6a125d94c1ab437 > src/master/registrar.hpp 98bfa1e83b7e6d28e011444a665155e31922446c > src/master/registrar.cpp cbb67bd17402692d3bb81fe58baea952897c56d1 > src/tests/registrar_tests.cpp 41836aeaf94e1b21e040b9e8ecf71e0b5a351f8e > > Diff: https://reviews.apache.org/r/19372/diff/ > > > Testing > ------- > > make check GTEST_FILTER=*Registrar* > > > Thanks, > > Jiang Yan Xu > >
