> On March 24, 2014, 6:59 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/metrics/counter.hpp, line 19 > > <https://reviews.apache.org/r/18718/diff/11/?file=534291#file534291line19> > > > > Let's kill Counter::set for now, what is the use-case for directly > > setting a Counter? > > Dominic Hamon wrote: > slave statistics include recoveryErrors which is best captured by a > counter that is directly set. > > Ben Mahler wrote: > Why can't it just use your increment(int) function to increment by the > number of errors? Seems like there is no need for Counter::set in that > example?
It would have to 'get' to find the current value then increment/decrement to the correct value. It seemed much simpler to have a 'set' method. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18718/#review38400 ----------------------------------------------------------- On March 25, 2014, 10:49 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18718/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 10:49 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-1036 > https://issues.apache.org/jira/browse/MESOS-1036 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/metrics/counter.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/gauge.hpp PRE-CREATION > 3rdparty/libprocess/include/process/metrics/metric.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metric.cpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.hpp PRE-CREATION > 3rdparty/libprocess/src/metrics/metrics.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/metrics_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/18718/diff/ > > > Testing > ------- > > Added unit tests. make check. > > > Thanks, > > Dominic Hamon > >
