----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/#review40628 -----------------------------------------------------------
Ship it! This looks great Tobi. Very minor nits from Vinod and I and then I'll get this committed ASAP. configure.ac <https://reviews.apache.org/r/20402/#comment73701> As Vinod mentioned below, we try and use proper punctuation in our comments, not a big deal, just a style aspect of our codebase. src/Makefile.am <https://reviews.apache.org/r/20402/#comment73700> Will running something like 'mvn clean' handle the first and last case of this target? Clearly we'll still need/want to delete the examples and generated headers ourselves. Not being a Maven guy it seems a bit weird not to have a call to 'mvn' to clean when we have a call to compile/package ... but maybe this is standard practice with Maven? - Benjamin Hindman On April 16, 2014, 11:56 p.m., Tobi Knaup wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20402/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 11:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Patrick Wendell. > > > Bugs: MESOS-1212 > https://issues.apache.org/jira/browse/MESOS-1212 > > > Repository: mesos-git > > > Description > ------- > > Use Maven to build the Mesos jars, and include shaded protbuf jar. > No longer builds a custom protobuf jar but relies on Maven. > > NOTE: #20329 (shading) is a breaking change for JVM frameworks which use the > com.google.protobuf namespace. These need to change to > org.apache.mesos.com.google.protobuf. > > Includes the dependent patch from https://reviews.apache.org/r/20329/ which > I'll delete once that's merged. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 560b4c7 > src/examples/java/test-exception-framework.in 26617e2 > src/examples/java/test-executor.in 8b27a37 > src/examples/java/test-framework.in bbdc1ed > src/examples/java/test-log.in b7e69e4 > src/examples/java/test-multiple-executors-framework.in eb8edf6 > src/java/mesos.pom.in 8f9b747 > > Diff: https://reviews.apache.org/r/20402/diff/ > > > Testing > ------- > > make check > make maven-install > > > Thanks, > > Tobi Knaup > >
