> On April 17, 2014, 1:02 a.m., Vinod Kone wrote: > > src/Makefile.am, line 570 > > <https://reviews.apache.org/r/20402/diff/2/?file=561414#file561414line570> > > > > End with period. > > > > Also, can you pull this down close to where it is used?
I think just putting it directly where it was defined before should be sufficient. Was there some reason that didn't work Tobi? > On April 17, 2014, 1:02 a.m., Vinod Kone wrote: > > src/Makefile.am, line 733 > > <https://reviews.apache.org/r/20402/diff/2/?file=561414#file561414line733> > > > > So this installs both the shaded and non-shaded versions with different > > names? > > > > What gets published when we do "mvn deploy -f src/java/mesos.pom" (e.g: > > support/tag.sh and support/vote.sh). > > > > Also, would you mind updating src/java/MESOS-MAVEN-README? What explicitly needs to get updated Vinod? I wouldn't know what you'd want me to update so I figured we should be a bit more explicit for poor Tobi. ;) - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/#review40620 ----------------------------------------------------------- On April 16, 2014, 11:56 p.m., Tobi Knaup wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20402/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 11:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Patrick Wendell. > > > Bugs: MESOS-1212 > https://issues.apache.org/jira/browse/MESOS-1212 > > > Repository: mesos-git > > > Description > ------- > > Use Maven to build the Mesos jars, and include shaded protbuf jar. > No longer builds a custom protobuf jar but relies on Maven. > > NOTE: #20329 (shading) is a breaking change for JVM frameworks which use the > com.google.protobuf namespace. These need to change to > org.apache.mesos.com.google.protobuf. > > Includes the dependent patch from https://reviews.apache.org/r/20329/ which > I'll delete once that's merged. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 560b4c7 > src/examples/java/test-exception-framework.in 26617e2 > src/examples/java/test-executor.in 8b27a37 > src/examples/java/test-framework.in bbdc1ed > src/examples/java/test-log.in b7e69e4 > src/examples/java/test-multiple-executors-framework.in eb8edf6 > src/java/mesos.pom.in 8f9b747 > > Diff: https://reviews.apache.org/r/20402/diff/ > > > Testing > ------- > > make check > make maven-install > > > Thanks, > > Tobi Knaup > >
