> On April 17, 2014, 11:49 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [20402] > > > > Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null > > > > Error: > > configure: WARNING: can not find python-boto > > ------------------------------------------------------------------- > > mesos-ec2 services will not function. > > ------------------------------------------------------------------- > > ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared > > 'extern' [enabled by default] > > ev.c: In function 'evpipe_write': > > ev.c:2160:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2172:17: warning: ignoring return value of 'write', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c: In function 'pipecb': > > ev.c:2193:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > ev.c:2207:16: warning: ignoring return value of 'read', declared with > > attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/c++/4.6/ext/hash_set:61:0, > > from src/glog/stl_logging.h:54, > > from src/stl_logging_unittest.cc:34: > > /usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning > > This file includes at least one deprecated or antiquated header which may > > be removed without further notice at a future date. Please use a > > non-deprecated interface with equivalent functionality instead. For a > > listing of replacement headers and interfaces, consult the file > > backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp] > > In file included from src/utilities.h:73:0, > > from src/googletest.h:38, > > from src/stl_logging_unittest.cc:48: > > src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by > > default] > > /usr/include/features.h:166:0: note: this is the location of the previous > > definition > > warning: no files found matching 'Makefile' under directory 'docs' > > warning: no files found matching 'indexsidebar.html' under directory 'docs' > > ar: creating libleveldb.a > > make[2]: *** [java/target/mesos-0.19.0.jar] Error 1 > > make[1]: *** [all-recursive] Error 1 > > make: *** [distcheck] Error 1 > >
Good news, it got past the configure check. Bad news, the review bot is still broken. :( - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20402/#review40640 ----------------------------------------------------------- On April 16, 2014, 11:56 p.m., Tobi Knaup wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20402/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 11:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Patrick Wendell. > > > Bugs: MESOS-1212 > https://issues.apache.org/jira/browse/MESOS-1212 > > > Repository: mesos-git > > > Description > ------- > > Use Maven to build the Mesos jars, and include shaded protbuf jar. > No longer builds a custom protobuf jar but relies on Maven. > > NOTE: #20329 (shading) is a breaking change for JVM frameworks which use the > com.google.protobuf namespace. These need to change to > org.apache.mesos.com.google.protobuf. > > Includes the dependent patch from https://reviews.apache.org/r/20329/ which > I'll delete once that's merged. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 560b4c7 > src/examples/java/test-exception-framework.in 26617e2 > src/examples/java/test-executor.in 8b27a37 > src/examples/java/test-framework.in bbdc1ed > src/examples/java/test-log.in b7e69e4 > src/examples/java/test-multiple-executors-framework.in eb8edf6 > src/java/mesos.pom.in 8f9b747 > > Diff: https://reviews.apache.org/r/20402/diff/ > > > Testing > ------- > > make check > make maven-install > > > Thanks, > > Tobi Knaup > >
