----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20955/#review42002 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20955/#comment75742> Shouldn't we be using getpwnam_r for thread safety? Would you mind fixing it? Either way, we can check errno (we need to set it to 0 if using getpwnam) to get a more informative error. I would suggest removing the 'user' bit because it's likely this will lead to double logging by callers (which assume that the callee is not going to show the 'user' that had an issue since that information is known to the caller). Ditto for getgid. 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20955/#comment75745> Shouldn't this be using getpwuid_r for thread safety? Would make for a good follow up fix! - Ben Mahler On May 1, 2014, 5:10 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20955/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 5:10 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These will be used for a later review where I need to pass uid and gid to a > forked child which will use the async signal safe ::setgid and ::setuid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > > Diff: https://reviews.apache.org/r/20955/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
