> On May 16, 2014, 4:54 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 782
> > <https://reviews.apache.org/r/20955/diff/3/?file=583729#file583729line782>
> >
> >     The result == NULL case is not possible here, right? Should we 
> > differentiate that by printing out a different message?

I believe it's still possible. Consider the scenario where the process is 
running as some user but that user account is forcefully removed from the 
system. ::getuid() always returns the uid but there may not be a username 
associated with that uid. Here I used `userdel -f testing` between the two id 
commands.
{noformat}
[testing@mesos tmp]$ id
uid=501(testing) gid=501(testing) groups=501(testing)
[testing@mesos tmp]$ id
uid=501 gid=501 groups=501
{noformat}


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20955/#review43288
-----------------------------------------------------------


On May 16, 2014, 3:08 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20955/
> -----------------------------------------------------------
> 
> (Updated May 16, 2014, 3:08 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> These will be used for a later review where I need to pass uid and gid to a 
> forked child which will use the async signal safe ::setgid and ::setuid.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 38756617ead1b6651e44ab989871ea3e68d130df 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
> 3e511355e1faf7160442799e1e08d59b6f3b2f37 
> 
> Diff: https://reviews.apache.org/r/20955/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to