----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20955/#review42215 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20955/#comment75989> Why not return ErrnoError()? 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/20955/#comment75990> ditto. - Vinod Kone On May 2, 2014, 10:02 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20955/ > ----------------------------------------------------------- > > (Updated May 2, 2014, 10:02 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These will be used for a later review where I need to pass uid and gid to a > forked child which will use the async signal safe ::setgid and ::setuid. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 38756617ead1b6651e44ab989871ea3e68d130df > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 94eb256d24bc001660d63bd91b608988205a3d09 > > Diff: https://reviews.apache.org/r/20955/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
