> On May 5, 2014, 11:24 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 151 > > <https://reviews.apache.org/r/21052/diff/2/?file=574065#file574065line151> > > > > Do you also want to add optional data that should be in the response?
I could ... given that other implementations I know don't do this I'll just add a TODO for now. > On May 5, 2014, 11:24 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, lines 160-163 > > <https://reviews.apache.org/r/21052/diff/2/?file=574065#file574065line160> > > > > the default values for interval_seconds and timeout_seconds seem to > > indicate that 2 health checks could be in flight. is that intended? No, the next health check won't fire until the last one completed, so it's (1) health check (2) wait timeout seconds (3) if got health check wait interval seconds else send next health check after timeout seconds. I'll update the comment appropriately. > On May 5, 2014, 11:24 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, lines 212-220 > > <https://reviews.apache.org/r/21052/diff/2/?file=574065#file574065line212> > > > > +1 doesn't seem to belong here. > > > > also, > > > > s/does currently not/currently does not/ This is just some cleanup related to me adding the 'health_check' field. Think of this like adding some new functionality where we move an if statement higher in a function because the code reads better when we do the if check sooner. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21052/#review42217 ----------------------------------------------------------- On May 3, 2014, 6:38 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21052/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 6:38 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-741 > https://issues.apache.org/jira/browse/MESOS-741 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto e48e50aae248bd9d5289dbaa36753be53b2e592a > src/master/master.cpp c79fdafde6b08d74e6fea71afa79aded41b3a9ab > > Diff: https://reviews.apache.org/r/21052/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
