> On May 5, 2014, 9:48 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 137 > > <https://reviews.apache.org/r/21052/diff/2/?file=574065#file574065line137> > > > > Shouldn't this be a hostname? > > Benjamin Hindman wrote: > I wasn't convinced that a hostname would be sufficient. For example, in > the event that we have internal containers that we're trying to query that > have private IP addresses (i.e., via Docker) it seemed like it was possible > we'd want to run mesos-health-checker both outside of such a container (in > which case the NAT'ing might be sufficient) or inside of a container in which > case it seemed like having an IP might be nice. I could have both with some > semantics about what to do if both are present. > > Niklas Nielsen wrote: > I was thinking along the lines of an full URL instead of ip + port + > path. That could accommodate hostname _and_ ip's too, would capture > http/https, port, login and so on. Are their downsides I am missing?
+1 Niklas. A full URL would be the most flexible here, and schedulers could readily derive this value at launchTasks() time. - Connor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21052/#review42207 ----------------------------------------------------------- On May 3, 2014, 6:38 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21052/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 6:38 a.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-741 > https://issues.apache.org/jira/browse/MESOS-741 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto e48e50aae248bd9d5289dbaa36753be53b2e592a > src/master/master.cpp c79fdafde6b08d74e6fea71afa79aded41b3a9ab > > Diff: https://reviews.apache.org/r/21052/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
