> On May 15, 2014, 6:32 a.m., Vinod Kone wrote:
> > can you run this script against a branch that has multiple commits and see 
> > if it works as expected?

Just tried this out, things seem to work as expected.


- Steven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21257/#review43094
-----------------------------------------------------------


On May 11, 2014, 7:07 p.m., Steven Phung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21257/
> -----------------------------------------------------------
> 
> (Updated May 11, 2014, 7:07 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1333
>     https://issues.apache.org/jira/browse/MESOS-1333
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> 1) Initially I was trying to use the post-reviews.py script to see if I could 
> create a review request since I never got post review installed and figured 
> out.  When I ran the program I ran into an exception when execute was called 
> which was because the command was accidentally passed in as two separate 
> arguments rather than a list of two arguments.
> 
> 2) Next, since I was using rbt 0.6 I ran into an issue where the revision 
> range was not a supported parameter anymore since it was previously 
> deprecated.  I've updated the way the command is built and considered if we 
> are using rbt or post-review.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 0ba14d8947cd7004a939c8b9b95deaab035be928 
> 
> Diff: https://reviews.apache.org/r/21257/diff/
> 
> 
> Testing
> -------
> 
> ./support/post-reviews.py
> 
> 
> Thanks,
> 
> Steven Phung
> 
>

Reply via email to