> On May 16, 2014, 5:51 p.m., Vinod Kone wrote: > > Hmm. I tested this on a branch with two commits. Neither the diffs nor the > > titles seem to be correct. Both the generated reviews had the same diff and > > title!?
That's not good... let me look into this further. Could you provide me the details of how you invoke post-reviews by chance? Maybe I'm not doing it in the same way and missing something obvious. - Steven ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21257/#review43226 ----------------------------------------------------------- On May 16, 2014, 2:02 a.m., Steven Phung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21257/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 2:02 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1333 > https://issues.apache.org/jira/browse/MESOS-1333 > > > Repository: mesos-git > > > Description > ------- > > 1) Initially I was trying to use the post-reviews.py script to see if I could > create a review request since I never got post review installed and figured > out. When I ran the program I ran into an exception when execute was called > which was because the command was accidentally passed in as two separate > arguments rather than a list of two arguments. > > 2) Next, since I was using rbt 0.6 I ran into an issue where the revision > range was not a supported parameter anymore since it was previously > deprecated. I've updated the way the command is built and considered if we > are using rbt or post-review. > > > Diffs > ----- > > support/post-reviews.py 0ba14d8 > > Diff: https://reviews.apache.org/r/21257/diff/ > > > Testing > ------- > > ./support/post-reviews.py > > > Thanks, > > Steven Phung > >
