> On May 16, 2014, 5:51 p.m., Vinod Kone wrote: > > Hmm. I tested this on a branch with two commits. Neither the diffs nor the > > titles seem to be correct. Both the generated reviews had the same diff and > > title!? > > Steven Phung wrote: > That's not good... let me look into this further. Could you provide me > the details of how you invoke post-reviews by chance? Maybe I'm not doing it > in the same way and missing something obvious. > > Steven Phung wrote: > Not to get off topic but do you think it would be worth considering > upgrading to rbt for contributions instead? > (https://issues.apache.org/jira/browse/MESOS-1357) > > The way post-reviews.py is going at the moment it would be this weird > interweaving between supporting both post-review and rbt. The reason for > this maintainability because their outputs and inputs are both slightly > different. As described in MESOS-1357 if we had an isolated version of rbt > it would be much less error prone. My guess as to the differences we are > seeing assuming I'm not an idiot is how our global installations differ. > > Steven Phung wrote: > More thinking aloud on the above topic. Maybe it would make the most > sense to separate rbt from post-review and then phase out post-review over > time. That seems pretty reasonable to me.
I'm using RBT 0.5.7. I tested this as follows: git co master git pull git co -b test_branch ...make some edits... git commit -am "commit 1" ...make some edits... git commit -am "commit 2" ./support/apply_review.sh 21257 # get the post-reviews update from this review. i modified the commit message to remove "Review:.." line so that I can create a new review for this commit too. # At this point my branch has 3 commits (2 of my own and 1 from this review) ./post-reviews.py # I expect this to produce 3 review requests for 3 commits. But it produces 3 reviews all with the same summary as "commit 3" and diff as "commit 3". - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21257/#review43226 ----------------------------------------------------------- On May 16, 2014, 2:02 a.m., Steven Phung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21257/ > ----------------------------------------------------------- > > (Updated May 16, 2014, 2:02 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1333 > https://issues.apache.org/jira/browse/MESOS-1333 > > > Repository: mesos-git > > > Description > ------- > > 1) Initially I was trying to use the post-reviews.py script to see if I could > create a review request since I never got post review installed and figured > out. When I ran the program I ran into an exception when execute was called > which was because the command was accidentally passed in as two separate > arguments rather than a list of two arguments. > > 2) Next, since I was using rbt 0.6 I ran into an issue where the revision > range was not a supported parameter anymore since it was previously > deprecated. I've updated the way the command is built and considered if we > are using rbt or post-review. > > > Diffs > ----- > > support/post-reviews.py 0ba14d8 > > Diff: https://reviews.apache.org/r/21257/diff/ > > > Testing > ------- > > ./support/post-reviews.py > > > Thanks, > > Steven Phung > >
