----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21723/#review43541 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/21723/#comment77751> are you going to add tests? src/master/master.cpp <https://reviews.apache.org/r/21723/#comment77749> would it make more sense to pass flags.acls here to avoid the check in the authorizer? src/tests/mesos.cpp <https://reviews.apache.org/r/21723/#comment77750> Try<JSON::Object> acls = JSON::Object(); should work. - Dominic Hamon On May 20, 2014, 1:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21723/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 1:34 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1387 > https://issues.apache.org/jira/browse/MESOS-1387 > > > Repository: mesos-git > > > Description > ------- > > Master just initializes the Authorizer with ACLs, doesn't do any > authorization yet. > > > Diffs > ----- > > src/authorizer/authorizer.hpp 75b5a33cc2d83016598e5858d537ce1106784b41 > src/master/flags.hpp db21ab02f799e1eb33de40b6aa964a7d0e6477c9 > src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f > src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 > src/tests/mesos.cpp 7e5e96a4de29b56a906716fc2e03ae4fce4a8584 > > Diff: https://reviews.apache.org/r/21723/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
