> On May 21, 2014, 11:39 p.m., Benjamin Hindman wrote:
> > src/authorizer/authorizer.hpp, line 284
> > <https://reviews.apache.org/r/21723/diff/1/?file=585504#file585504line284>
> >
> > Why is this an error? Why not just assume an empty flags.acls is equal
> > to '{}'?
The main reason is that I want Master to instantiate an Authorizer only when
ACLs are specified (they could be {} but that is still considered specified).
That way we can turn off the Authorizer code path (for whatever reason) by not
specifying the "acls" flag. Given these semantics, it seems odd to silently
assume flags.acls.isNone() is equivalent to "{}". I would rather the user of
Authorizer think about this. Do you have any use case in mind where your
suggestion makes sense?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21723/#review43674
-----------------------------------------------------------
On May 20, 2014, 8:34 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21723/
> -----------------------------------------------------------
>
> (Updated May 20, 2014, 8:34 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1387
> https://issues.apache.org/jira/browse/MESOS-1387
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Master just initializes the Authorizer with ACLs, doesn't do any
> authorization yet.
>
>
> Diffs
> -----
>
> src/authorizer/authorizer.hpp 75b5a33cc2d83016598e5858d537ce1106784b41
> src/master/flags.hpp db21ab02f799e1eb33de40b6aa964a7d0e6477c9
> src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f
> src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673
> src/tests/mesos.cpp 7e5e96a4de29b56a906716fc2e03ae4fce4a8584
>
> Diff: https://reviews.apache.org/r/21723/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
