> On May 20, 2014, 9:38 p.m., Dominic Hamon wrote: > > src/master/master.cpp, line 339 > > <https://reviews.apache.org/r/21723/diff/1/?file=585507#file585507line339> > > > > are you going to add tests?
i did. by specifying acls in mesos.cpp :) more tests will be added in subsequent reviews when the authorizer is actually used to do something. > On May 20, 2014, 9:38 p.m., Dominic Hamon wrote: > > src/master/master.cpp, line 341 > > <https://reviews.apache.org/r/21723/diff/1/?file=585507#file585507line341> > > > > would it make more sense to pass flags.acls here to avoid the check in > > the authorizer? the reason i have flags here is because in the future i imagine there would be more ACL specific flags (e.g., --ldap_user, --ldap_password) that need to be passed in. im ok with takings JSON<Object> for now and revisit in the future. that likely also addresses benh's comment below. thoughts? > On May 20, 2014, 9:38 p.m., Dominic Hamon wrote: > > src/tests/mesos.cpp, line 103 > > <https://reviews.apache.org/r/21723/diff/1/?file=585508#file585508line103> > > > > Try<JSON::Object> acls = JSON::Object(); > > > > should work. done - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21723/#review43541 ----------------------------------------------------------- On May 20, 2014, 8:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21723/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 8:34 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1387 > https://issues.apache.org/jira/browse/MESOS-1387 > > > Repository: mesos-git > > > Description > ------- > > Master just initializes the Authorizer with ACLs, doesn't do any > authorization yet. > > > Diffs > ----- > > src/authorizer/authorizer.hpp 75b5a33cc2d83016598e5858d537ce1106784b41 > src/master/flags.hpp db21ab02f799e1eb33de40b6aa964a7d0e6477c9 > src/master/master.hpp 5e0d712de997bd10079655df9b07099284f8257f > src/master/master.cpp 075755cad5c50a57c92d7d82f2466b467796f673 > src/tests/mesos.cpp 7e5e96a4de29b56a906716fc2e03ae4fce4a8584 > > Diff: https://reviews.apache.org/r/21723/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
